[java] Ensure retry mechanism does not swallow an exception #12838
Conversation
| private static final Fallback<Object> fallback = | ||
| Fallback.of( | ||
| executionAttemptedEvent -> { | ||
| if (executionAttemptedEvent.getLastException() != null) { |
There was a problem hiding this comment.
Given the length of this, I'd suggest pulling out it out into a private method in this class. It'll make it easier to visually figure out the fields of the class from the methods it contains.
There was a problem hiding this comment.
Ahh makes sense. Thank you! Will do that.
pujagani
force-pushed
the
fix-retry-mechanism
branch
from
daf4260
to
87ed342
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12838 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 86 86
Lines 5255 5255
Branches 187 187
=======================================
Hits 2970 2970
Misses 2098 2098
Partials 187 187 ☔ View full report in Codecov by Sentry. |
|
Does this fix #12558 or just related to the discussion there? |
|
@pujagani thanks for fixing this 😀 |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Ensure retry mechanism does not swallow an exception
Motivation and Context
Related to #12558 (comment).
Types of changes
Checklist